Rust: Unused variable follow-up work #17744
Conversation
geoffw0
changed the title
|
DCA shows we still get 472,005 results for |
|
I've removed the second commit (force push) because we're clearly not quite there yet. This PR is not just correcting the test annotations. |
| @@ -111,7 +111,7 @@ fn arrays() { | |||
|
|
|||
| println!("lets use {:?}", js); | |||
|
|
|||
| for k // SPURIOUS: unused variable [macros not yet supported] | |||
| for k | |||
There was a problem hiding this comment.
Now that the comment is no longer there, it might be nicer to remove the linebreak before in (in all three cases)?
There was a problem hiding this comment.
I don't like the idea of changing formatting around just because query results change. If it was correct to split the for loop into two lines before (so that any results on k or ks are clearer), it's still justified now IMO.
I'm admittedly not an unbiased source as changing this would require me to fix up a couple of other commits I have ready. If you don't agree with my justification, say so and I'll make the change after all my work on this is merged.
Changes to unused variable.
.expectedresults in Rust: add macro expansion to the extractor #17659 .disable the workaround for--- still too noisyrust/unused-variablebeing too noisy.